Add support for league/flysystem 2 #87
Conversation
|
Great work, @lruozzi9! Can you add this file: src/FeedContext/Google/Shopping/ProductItemContext.php to the ignored files in Psalm? I think that's the file that makes Psalm exhaust its memory limit. Then we should be able to make it build |
|
@loevgaard ok, but now there are a lot of errors already existing in master 😅. If you want I can try to fix the ones about this PR and add others to the baseline. Or add all to the baseline? |
|
Haha, I see :D The ones related to your change would be great to have fixed, so we don't add more errors. Thank you! |
lruozzi9
force-pushed
the
upgrade-league-flysystem
branch
2 times, most recently
from
94b90d9 to
60eccd1
Compare
|
@loevgaard I think now it is quite acceptable! |
lruozzi9
force-pushed
the
upgrade-league-flysystem
branch
2 times, most recently
from
46b978d to
623f6d8
Compare
|
@loevgaard Now here we are! I fixed an error due to the missing getMainRequest() method on Symfony 4. |
lruozzi9
force-pushed
the
upgrade-league-flysystem
branch
from
27c9285 to
623f6d8
Compare
|
Good morning, @lruozzi9. I chose to make the Can you rebase onto Thank you for all your work! |
lruozzi9
force-pushed
the
upgrade-league-flysystem
branch
2 times, most recently
from
983be26 to
ce25ccc
Compare
lruozzi9
force-pushed
the
upgrade-league-flysystem
branch
from
ce25ccc to
6f31517
Compare
|
Here we are @loevgaard! |
|
Thank you very much, @lruozzi9 🎉 Great work! |
Differently from #69, these changes will support both v1 and v2 of league/flysystem.
@loevgaard what do you think? So that we can support Sylius 1.12 without any BC!